Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/975
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-152660873
#1015 made to apply my remarks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-152566972
@dahn are you OK to merge this as-is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-152195378
@snuf Can you respond to the comment by @dahn? Then we can proceed to merge
this. Thanks!
---
If your project is set up for it, you can reply to this email and
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-152189257
Ping @remibergsma @snuf
I did not test any OVM3 specifics, but @snuf did. The PR doesn't break
existing functionality.
Although the
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-152127664
Ping @remibergsma @snuf
Just started testing this PR.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-152379017
Sorry guys been a bit in flight, yes @DaanHoogland has point but tbh we
should fix that everywhere in one go for all the hypervisors not to be a
dick, but just
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150917774
@remi: yep did the OVM3 dance, together with KVM and separately from OVM3.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150946842
@DaanHoogland Could you please do a code review of this PR? Thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150965104
Pinging @snuf to respond to the comment here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/975#discussion_r42948653
--- Diff:
plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/resources/Ovm3HypervisorGuru.java
---
@@ -105,9 +105,6 @@ public boolean
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150959103
one comment, code looks fine otherwise
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150782431
@snuf We may want to run a specific test against OVM3, I assume you did
that? The above tests just show you didn't break anything else :-)
---
If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150782142
@snuf Thanks! LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
14 matches
Mail list logo
