Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-222531254
### ACS CI BVT Run
**Sumarry:**
Build Number 90
Hypervisor xenserver
NetworkType Advanced
Passed=68
Failed=5
Skipped=3
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-216198487
@SudharmaJain please rebase against master and push -f, and update on
status of your PR, thanks
LGTM
tag:easypr
---
If your project is set up for
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-215365287
@SudharmaJain Any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-158673310
@SudharmaJain Any update on this? Please respond to the comments, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-152275904
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-152279403
@SudharmaJain Your change looks good at first sight. Did you verify that
your intended behaviour actually happens? and how? The name of the vpn is now
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-150773033
@SudharmaJain These are the results of tests that I run on this branch:
```
Create a redundant VPC with two networks with two VMs in each network ...
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-150032995
@SudharmaJain Thanks for the fix. There is a Marvin test covering VPN.
Maybe add a test there?
---
If your project is set up for it, you can reply to this
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-149494651
Hi @SudharmaJain,
Any test to cover your changes? In case no, how should we test this PR?
Which steps to follow?
Cheers,
Wilder
---
GitHub user SudharmaJain opened a pull request:
https://github.com/apache/cloudstack/pull/955
CLOUDSTACK-8969 VPN customer gateway can't be registered with hostname
When we have VPN customer gateway which is resolved by a hostname , we
should be able to register the VPN customer
10 matches
Mail list logo
