Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1016#issuecomment-153027106
I liked that ordering better...seems more logical: 1) customized IOPS
(true/false), 2) Min IOPS, and 3) Max IOPS (2 and 3 are ignored by the
backend
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1016#issuecomment-153133444
Thanks! I went ahead and closed
https://issues.apache.org/jira/browse/CLOUDSTACK-9008.
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1016#issuecomment-153027488
so in English: for readability. makes sense ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1016#issuecomment-153002626
LGTM based on code inspection (Why the move of the customizediops bits?
harmless but senseless)
---
If your project is set up for it, you can reply to this
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1016#issuecomment-153000915
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1016
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1016#issuecomment-152707311
Hi @mike-tutkowski thanks for the details in the jira ticket and the pr.
From a quick look it looks good but when i'm at my laptop again I will run some
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1016#issuecomment-152785924
What I did was run a Marvin test I have that creates a VM whose root disk
is placed on managed storage. The test then creates a hypervisor snapshot of
the
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/1016
CLOUDSTACK-9008 - Pass hypervisor snapshot reserve field in when creaâ¦
â¦ting compute and disk offerings
https://issues.apache.org/jira/browse/CLOUDSTACK-9008
You can merge
