Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1043
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1043#issuecomment-155079219
LGTM, browsed around in UI in German and Chinese and didn't see Javascript
errors.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1043#issuecomment-154878848
Changed LGTM. No integration tests ran though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1043#issuecomment-154861335
code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/1043
CLOUDSTACK-9043 Remove \n (new line) in German and Chinese translation
The new line isn't in the original strings and are invalid character in the
javascript files/ui