Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1062
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-157418578
Closing this pull request now that it has been created against the 4.6
branch in PR #1079
---
If your project is set up for it, you can reply to this email and ha
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-157411446
I've created the PR against 4.6 now.
https://github.com/apache/cloudstack/pull/1079
---
If your project is set up for it, you can reply to this email and h
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-157410651
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-157409534
This was tested situationally. Not perfect, but we don't have the
Cloudstack test-suite setup yet. Not sure I will have time to do that now.
The following s
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-157393161
How did you test it, @dsclose?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-156984813
@dsclose Can you please make this PR against 4.6 branch? After merge it
will be fwd-merged to master. Thanks!
---
If your project is set up for it, you can rep
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-156121380
@dsclose Thanks, I will also run some tests on this branch and report back
later.
---
If your project is set up for it, you can reply to this email and have yo
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-156116335
In old password server (serve_password.sh), it return "saved_password" if
the password is empty.
now it is set to empty in passwd_server_ip.py.
our scrip
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1062#issuecomment-156103338
As with my other pull request, I only used situational tests for this. I'll
look into the docs to get the marvin tests up and running and will update this
issue in
10 matches
Mail list logo
