Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1083
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-158344376
@remibergsma Of course I tested manually! Nice Jenkins Job btw ;)
I see three LGTM's, two of which are based on code review, one on running
integration t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-158341279
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first). Screenshot is from an experimental Jenkins job (that runs the
same tests
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-158328981
LGTM. Reviewed the code and looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-158062783
@wilderrodrigues Fixed your comments, refactoring is for the next round ;)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-158048085
@borisroman @wido I made some comments in the PR. Those are not blocking,
but would be very fruitful to get them in place in a second round of the
refactor.
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1083#discussion_r45335913
--- Diff: core/src/com/cloud/storage/template/S3TemplateDownloader.java ---
@@ -342,47 +274,38 @@ public InputStream getS3ObjectInputStream() {
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1083#discussion_r45335845
--- Diff: core/src/com/cloud/storage/template/S3TemplateDownloader.java ---
@@ -19,303 +19,235 @@
package com.cloud.storage.template;
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1083#discussion_r45335326
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/storage/AddImageStoreS3CMD.java
---
@@ -201,15 +209,15 @@ public int hashCode() {
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1083#discussion_r45335015
--- Diff: api/src/com/cloud/agent/api/to/S3TO.java ---
@@ -155,6 +161,7 @@ public int hashCode() {
result = 31 * result + (secretKey
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1083#discussion_r45335103
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/storage/AddImageStoreS3CMD.java
---
@@ -119,17 +129,16 @@ public void execute() throws
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1083#discussion_r45334945
--- Diff: api/src/com/cloud/agent/api/to/S3TO.java ---
@@ -51,8 +52,8 @@ public S3TO() {
}
public S3TO(final Long id, fina
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-157697285
@DaanHoogland You're right. Forgot to remove it in my last iteration.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
re
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-157683314
@borisroman checkstyle reports unused imports
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1083#discussion_r45187932
--- Diff: core/src/com/cloud/storage/template/S3TemplateDownloader.java ---
@@ -19,303 +19,236 @@
package com.cloud.storage.template;
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-157657472
Initially it looks good, but with S3 it's very hard to test this. At a
first glance the code looks good. Much better then it was
---
If your project is set up for it,
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1083#issuecomment-157551229
Ping @wido @remibergsma @wilderrodrigues @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1083
CLOUDSTACK-9062: Improve S3 implementation.
The S3 implementation is far from finished, this commit focuses on the
bases.
- Upgrade AWS SDK to latest version.
- Rewrite S3 Tem
18 matches
Mail list logo
