Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1109#issuecomment-160585862
@wido @remibergsma do we want this on 4.5?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1109#issuecomment-160190463
reviewed the code. except for the use of English in comments it looks fine.
LGTM
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1109#issuecomment-159936201
Quickly tested for the docker images, behave correctly.
LGTM
Thanks!
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1109#issuecomment-159564428
@pdion891 Thanks, please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1109#issuecomment-159130294
@remibergsma can you update this PR with following update:
It still need to look for ``/dev/loop0`` inside docker to know if it can
update the sshkey at the
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1109
CLOUDSTACK-9077 Fix injectkeys.sh to work on CentOS7
Fix regression from commit 3381154fafb7fa4f0a61d538f7c2550e48247787
The error seen on CentOS 7:
```
2015-11-20
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1109#issuecomment-158973082
@remibergsma Thanks for this PR, this will break the injection of the ssh
key in the initial build of the docker container. But I will submit a PR to fix
the
