[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

2015-12-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1139#issuecomment-160908402 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

2015-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

2015-11-30 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1139#issuecomment-160591699 Not tested, but code is good. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

2015-11-29 Thread harikrishna-patnala
Github user harikrishna-patnala commented on the pull request: https://github.com/apache/cloudstack/pull/1139#issuecomment-160531359 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

2015-11-29 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/1139 CLOUDSTACK-9092: L10n fix in "Add LDAP Account page" fixed two strings on the "Add LDAP Account page" After the change: (with a test string in messages_ja_JP.properties file)