Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/1157#issuecomment-212815918
went through code.
LGTM. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1157#issuecomment-212760624
LGTM based on code review :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1157#issuecomment-212531389
I think we are just missing 1 LGTM for this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/1157#issuecomment-212408609
Rebased against master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/1157#issuecomment-212360074
@pedro-martins On line 503, It is not a function but It is a way to define
callback method. It has been used all over the cloudstack code. On line 504,
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1157#issuecomment-175685066
@SudharmaJain can you comment on @pedro-martins 's comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1157#issuecomment-174213096
@ SudharmaJain why are you passing null to the method that you created
(âcreateTemplateAsyncCallBackâ) at line 503?
That will cause a null pointer
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1157#issuecomment-161918736
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
GitHub user SudharmaJain opened a pull request:
https://github.com/apache/cloudstack/pull/1157
CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREATE event missing for usage_eâ¦
â¦vent by template sync thread
If there is a Management server restart while template is in downloading
10 matches
Mail list logo
