Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/1199#issuecomment-182284142
Rebased with current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1199#issuecomment-181041357
@pritisarap12 Could you please rebase this against the current master?
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user shwetaag commented on the pull request:
https://github.com/apache/cloudstack/pull/1199#issuecomment-179035607
Did code review. Code looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1199#issuecomment-172463466
LGTM
based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1199#issuecomment-172248830
@pvr9711 I guess you know what we need before merge, don't you? ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1199#issuecomment-168940359
LGTM !!
Test Results:
===
Check Snapshots size in database ... === TestName:
test_02_snapshot_size_check | Status : SUCCESS ===Â
okÂ
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/1199#issuecomment-166878523
@remibergsma can you merge these changes? thanks, Raja
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1199#discussion_r47465783
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self):
)
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1199#discussion_r47465693
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self):
)
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1199#discussion_r47431243
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self):
)
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1199#discussion_r47431233
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self):
)
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/1199#issuecomment-163163707
Testcase result:
Check Snapshots size in database ... === TestName:
test_02_snapshot_size_check | Status : SUCCESS ===
ok
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/1199
CLOUDSTACK-9128: Testcase to verify physical_size attribute of
snapshot_store_ref table
Verify if physical_size attribute of snapshot_store_ref table stores actual
physical size of the s
14 matches
Mail list logo
