Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-175560143
2 PRs, merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-170454494
@remibergsma ping, let's merge this before the freeze?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-167042039
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-165062191
@agneya2001 your solution LGTM
@remibergsma will you put it in your regression suite anyway? It does run
in the bubble (limitation of warranty; I teste
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-165001244
Moving the test to test/integration/plugins folder as in most automated
environment this will either fail or not run, due to the MS restart required
to enable t
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164652898
@DaanHoogland this is what I did:
1. Created a simulator environment
2. Deployed the datacenter using the cfg above,
3. checked the DB and confirmed t
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164483340
@agneya2001 The definition as I gave you is used in th 'bubble' to create
the environment (including settings) before running the test in a
deployDatacenter.py
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164432291
@DaanHoogland I have put a check that if the quota is not enabled then the
tests are skipped. I tried enabling quota from inside the test, but it requires
a MS r
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1240#discussion_r47484456
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -186,7 +186,7 @@ public int compare(Qu
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1240#discussion_r47484403
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -186,7 +186,7 @@ public int compare(Qu
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164406128
i used this file, not all is relevant but the global setting for it are in
there.
```
# Licensed to the Apache Software Foundation (ASF) under one
#
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164405451
@DaanHoogland Let me add the DC definition, I still need to figure the
howto part.
---
If your project is set up for it, you can reply to this email and have yo
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1240#discussion_r47481989
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -186,7 +186,7 @@ public int compare(Quot
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164401474
@agneya2001 code looks good, one question about the logic. will run the
test.
As this test requires global settings in the server, it would pay to add
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1240#discussion_r47480556
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -186,7 +186,7 @@ public int compare(Qu
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1240
CLOUDSTACK-9161: fix the quota marvin test
1. Create a dummy user, as existing user may already have stale quota
data
2. fix the tests to use the dummy user
3. a boundary
17 matches
Mail list logo
