[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2016-05-28 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1246#issuecomment-222328207 ### ACS CI BVT Run **Sumarry:** Build Number 75 Hypervisor xenserver NetworkType Advanced Passed=68 Failed=5 Skipped=3 _

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2016-05-09 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1246#issuecomment-217875751 @SudharmaJain, I've added a few comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2016-05-09 Thread nlivens
Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1246#discussion_r62503852 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1588,6 +1588,16 @@ protected StringBuilder createGuestBoot

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2016-05-09 Thread nlivens
Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1246#discussion_r62503776 --- Diff: server/src/com/cloud/network/guru/GuestNetworkGuru.java --- @@ -396,6 +396,16 @@ public NicProfile allocate(final Network network, NicProfile n

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2016-05-09 Thread nlivens
Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1246#discussion_r62503830 --- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java --- @@ -755,6 +755,16 @@ protected HypervisorType getClusterToStartDomainRouterForOv

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1246#issuecomment-216208690 @SudharmaJain can you rebase against latest master and share state of your PR, thanks tag:easypr --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2016-04-19 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/1246#issuecomment-212258625 @alexandrelimassantana I have made changes with respect to ur last comment. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2016-01-24 Thread alexandrelimassantana
Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1246#issuecomment-174398371 Hello, there is also something bugging me with this piece of code which appears on the changed files: ```java final String gatewayCidr = g

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2016-01-15 Thread pedro-martins
Github user pedro-martins commented on the pull request: https://github.com/apache/cloudstack/pull/1246#issuecomment-172029080 Hi =) What is the difference between network.getCidr() and network.getNetworkCidr() ? And, there is a possibility to you create a method with a simple

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

2015-12-15 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1246 CLOUDSTACK-9165 unable to use reserved IP range in a network for exte… …rnal VMs Repro Steps -- 1. Create an isolated network with CIDR 192.168.200.0/2