[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-05-28 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-222320117 ### ACS CI BVT Run **Sumarry:** Build Number 74 Hypervisor xenserver NetworkType Advanced Passed=73 Failed=0 Skipped=3 _

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-05-27 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1257#issuecomment-92187 ### ACS CI BVT Run **Sumarry:** Build Number 70 Hypervisor xenserver NetworkType Advanced Passed=73 Failed=0 Skipped=3 _

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-05-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1257#issuecomment-221216726 would like to see this fixed, @sureshanaparti can I help you out? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1257#issuecomment-216211328 @sureshanaparti please rebase against latest master, thanks tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-216208737 @sureshanaparti can you rebase against latest master and share state of your PR, thanks; squash all changes into a single commit tag:vmware-pickup --- If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-04-27 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1257#issuecomment-215326963 @sureshanaparti There are some open items, please address them --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-03-30 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1257#issuecomment-203755658 ### ACS CI BVT Run **Sumarry:** Build Number 150 Hypervisor xenserver NetworkType Advanced Passed=103 Failed=1 Skipped=4

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-02-28 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1257#discussion_r54359804 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java --- @@ -1110,4 +1148,39 @@ public String getNetworkName(String netMorVal) th

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-02-22 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-187360919 @sureshanaparti yes, that would be great --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-02-07 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-181232447 @resmo Shall I close this PR (as #1257 replaces this one)? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-01-24 Thread rodrigo93
Github user rodrigo93 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1257#discussion_r50639477 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -138,6 +142,8 @@ @Inject

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-18 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165715666 @resmo ok sure. thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-18 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165712661 since #1257 replaces this PR I would do so, yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165547302 @resmo Raised a clean PR: https://github.com/apache/cloudstack/pull/1257. Shall I close this one? --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1257 CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. Summary: When a new host is added to a cluster, Cloudstack doesn't create all the po

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165414155 @resmo Sure. I'll do that. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165413590 @sureshanaparti that would be great. appreciate your work on vmware parts! --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165412102 @resmo, You mean findOldestExistentHypervisorHostInCluster. I'm OK with it. Shall I create new PR without all these merges? --- If your project is set u

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165410616 @sureshanaparti Ok, I see. then I would indeed use old but suggest `oldest` : `findExistentHypervisorHostInCluster`. Would you mind rebasing to get a clean PR withou

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-16 Thread sureshanaparti
Github user sureshanaparti commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165339578 @resmo, Out of all the running hosts present in the cluster, the port groups are fetched from the host which was first added to the cloudstack, assuming that

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-16 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165088002 `older` is a bit misleading, what about `existent` e.g. findExistentHypervisorHostInCluster? --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-16 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1248 CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. Summary: When a new host is added to a cluster, Cloudstack doesn't create all the po