Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-176108973
@bhaisaab actually I am not even seeing the travis runs here anymore.
Reason I am asking is genuine (again), because in the last few months
Travis has shown
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-176055926
@runseb checked the diff, travis/jenkins passed, diff looked good to me.
I've merged this and few others without integration tests as they *don't*
explictly nee
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-175834162
@bhaisaab @pdube @DaanHoogland @koushik-das lots of LGTM here , so great.
but we don't know why you LGTM'd and as far as I know no tests were run...
---
If your pro
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-175688521
LGTM, merging based on comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-167135604
Null check LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-167040113
@pdube That part is handled elsewhere. Here we are concerned about syncing
of VM metadata. So here if the VM is not in cloud DB then we are ignoring it.
---
If
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166910961
Shouldn't we log this information? Doesn't this mean that some resources
could be freed up on the hypervisor?
---
If your project is set up for it, you can reply to
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166824866
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166799368
@DaanHoogland Updated the descrition
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166611273
LGTM but please describe (preferable in a unit test) what situation is
prevented from happening here.
---
If your project is set up for it, you can reply to t
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/1274
CLOUDSTACK-9196: Fixing null pointer exception when vm meta data is synced
on upgraded setup
https://issues.apache.org/jira/browse/CLOUDSTACK-9196
You can merge this pull request into a Git
12 matches
Mail list logo
