Github user nislim commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-173123805
Same result with the refactored code:
```
root@v-23-VM:~# route -n
Kernel IP routing table
Destination Gateway Genmask Flags
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1352
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-172975452
If this helps @nislim And is tested it should go in.
I feel uncertain of this functionality. It is called from sestro and
console proxy setup functions but
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-172977865
@DaanHoogland I think we agree cloud-early-config needs major refactoring
as it is one big copy/paste thing. Just don't think this is the time to do it.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-173005222
`cloud-early-config` now logs:
```
Not setting up route of RFC1918 space to 192.168.22.1 befause 192.168.23.2
is RFC1918..
```
Routes
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-173002828
@nislim Can you please test the enhanced patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-173002681
Discussed with @DaanHoogland and he sent me a patch ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1352#discussion_r50168987
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -1166,6 +1166,9 @@ setup_storage_network() {
}
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-173112205
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1352
CLOUDSTACK-9244 Fix setting up RFC1918 routes
Public ip var was empty so routes were always set. Corrected this.
You can merge this pull request into a Git repository by running:
$
Github user nislim commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-172929285
Fixed my problem, my routing tables are now looking as I expected.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply
11 matches
Mail list logo
