Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1358
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-174600362
Thanks @borisroman and @remibergsma .
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-174492298
LGTM :+1:
Based on integration tests and code-review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-174210065
Ping @borisroman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-174210050
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-173902040
Problem fixed!
Ping @remibergsma @borisroman
* Delete ACL that contains items via Cloud Monkey
```
(local) ðµ > delete networkacl
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-173865670
Found and issue when destroying the VPC. Will fix it and update the PR.
```
(local) ðµ > delete vpc id=be232d77-495e-4f89-9b89-972db6a2efc5
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-173860410
Ping @remibergsma @borisroman @michaelandersen
Manual tests:
* Deleting attached ACL
![image](https://cloud.githubusercontent.com/
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1358
CLOUDSTACK-9245 - Cannot delete non-attached ACL that contains items
This PR fixes the issue when trying to delete ACL lists which contain item.
It seemed it was not thought of