[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

2016-01-26 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1364#issuecomment-174884655 Routes are supposed to be to networks when going out, so this makes sense. production at sbp is good enough a test for me: LGTM --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

2016-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

2016-01-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1364#issuecomment-174863942 `cat /etc/cloudstack/staticroutes.json` before and after change: Before always had one entry: ``` { "10.135.255.10": {

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

2016-01-25 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1364#issuecomment-174861340 LGTM :+1: Already running in production at SBP! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9256 add unique key for static...

2016-01-25 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1364 CLOUDSTACK-9256 add unique key for static routes in json Static routes that are being set do not show up in the static_routes.json file. The reason for this is that the index that is used,