Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197375867
Ideally, at some point in the future, we should rename
XenserverSnapshotStrategy to something more generic (maybe
DefaultSnapshotStrategy or something).
--
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197376318
Perhaps I'll rename it in 4.9 (probably not a good idea to do so in 4.7 and
then move the name change up to 4.8 and 4.9).
---
If your project is set up for
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1441#discussion_r56507303
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -279,7 +282,52 @@ public bo
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197929660
Hi @rafaelweingartner Thanks for the comments.
Just wanted to point out that if the revertSnapshot method is invoked, then
that is actually a failure
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197375495
Thanks, @ustcweizhou!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197892051
@mike-tutkowski could you fix the PR title and improve its description (a
brief description of the problem and solution would do)?
Additionally,
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197164602
tested on KVM, it is good.
so XenserverSnapshotStrategy LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/1441
CLOUDSTACK-9297: delete snapshot without id is failing with Unable toâ¦
⦠determine the storage pool of the snapshot
You can merge this pull request into a Git repository by running:
