Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60716681
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
---
@@ -0,0 +1,116 @@
+// L
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60716885
--- Diff: client/tomcatconf/commands.properties.in ---
@@ -799,3 +799,14 @@ quotaCredits=1
quotaEmailTemplateList=1
quotaEmailTemplateUpdate=1
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213375165
Pinging for review @jburwell @swill @wido @pyr @koushik-das @agneya2001
@DaanHoogland @rafaelweingartner @GabrielBrascher @kishankavala
---
If your project is se
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60725627
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForHostCmd.java
---
@@ -0,0 +1,107 @@
+
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60726125
--- Diff: api/src/org/apache/cloudstack/api/response/ZoneResponse.java ---
@@ -233,6 +234,9 @@ public void addTag(ResourceTagResponse tag) {
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213391362
I did an one hour code review and found nothing that will make me :-1: it
so; LGTM @swill I will however start integration tests and find more time as
the siz
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60727764
--- Diff: api/src/org/apache/cloudstack/api/response/ZoneResponse.java ---
@@ -233,6 +234,9 @@ public void addTag(ResourceTagResponse tag) {
}
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213395335
@DaanHoogland thanks, @borisstoyanov will share QA results next week as well
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213421943
Thanks guys. I will try to get this one queued up for CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213423589
Really exciting PR @bhaisaab!
We'll pull this in for testing as well.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213520037
Thanks @swill @kiwiflyer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213592386
@swill I am running the tests on this one. You want to both run it or beat
me at it?
---
If your project is set up for it, you can reply to this email and hav
Github user pyr commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213593763
First read-through didn't raise any eyebrows on my end. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213605569
Perfect thanks @DaanHoogland. Once we get more people using bubble, maybe
we can start posting to the PR that we are kicking off a CI run (like you did
here) so we c
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213616553
ok, @swill reporting without upr. two manual retests did make it equal in
effort.
all regular bubble tests passed on this except for the two I never ge
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213617967
@DaanHoogland thanks, in your test environment you'll need to install
ipmitool (yum/apt-get) and the oobm tests would pass. These tests are also run
by Travis, and se
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213618402
@DaanHoogland additional notes on how tests work; we've introduce a new
dependency `ipmisim` that I wrote for this feature, ipmisim is both a tool and
a library that
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60825819
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
---
@@ -0,0 +1,127 @@
+// Licensed t
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60825823
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
---
@@ -0,0 +1,127 @@
+// Licensed t
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213702911
I added a few comments, but before I continue:
- Why assume a IP-Address and not a hostname OR IP? I know enough IPMIs why
are available through a DNS hostname
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60885367
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
---
@@ -0,0 +1,127 @@
+// Licensed
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60885329
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
---
@@ -0,0 +1,127 @@
+// Licensed
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214233279
@wido thanks for the comments. It seemed easier to pass the arguments to
the oobm subsystem, there is a immutable map of option,string being returned
this is why all
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60890271
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
---
@@ -0,0 +1,127 @@
+// Licensed
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60890292
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
---
@@ -0,0 +1,127 @@
+// Licensed
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214257913
Marvin Init Successful
=== TestName: test_oobm_background_powerstate_sync | Status : SUCCESS ===
=== TestName: test_oobm_change_password | Status
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214636312
Thank you @DaanHoogland @pyr @wido for the review
@swill I think we've enough votes for this one, though le'ts wait for
@borisstoyanov 's test results which h
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214637482
>@rhtyd maybe in a follow-up; can we split the test in hardware required
true and false?
@DaanHoogland for this feature's integration test, we don't need an
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214667168
@rhtyd got ya. It will work like this but then still some tests require the
simulator which is hardware in a sense. I'm just thinking, not commenting.
---
If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214796529
@rhtyd not really related to this PR, but a question I have. How should we
be tracking environment change requirements? Ideally we would have a mechanism
to flag th
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214797513
I think this PR is in pretty good order. I will let @jburwell have a look
at it to see if he has any comments because it is a large PR, but pending any
of his feedba
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214824625
@swill,what are those changes you are refering too? are they required for
regular deployment or just for tests? anyway we will need some info for the
release notes
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214826838
@pdion891 sorry I kind of just threw you into this one. In this case there
is a new requirement added for tests integration tests to pass, so it is not a
blocking ch
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214840213
shouldn't we have a wiki page explaining how to do tests agains cloudstack?
and this would be part of this page or a subpage ?
---
If your project is set up for i
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214858085
@swill @pdion891 thanks, I don't know of any format or wiki/document where
we keep this thing. Each feature/marvin-test may require test specific
environment so I'm n
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214887358
@swill I am going to start in my review later this evening. Sorry for the
delay.
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-214889780
@rhtyd ya, I am not too worried about this PR. I think we are all set with
this PR once @jburwell has a chance to do a quick once through. This PR just
prompted me
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216229281
PR is code complete with testing efforts that @borisstoyanov can share
tag:mergeready
---
If your project is set up for it, you can reply to this email and h
Github user borisstoyanov commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216271049
Marvin tests where successful. Testing community submission of OOBM, which
includes end to end regression testing with IPMI simulator. Issue power state
comma
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216274536
I think this one is ready to merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216274944
@jburwell I will be doing a group of merges in a couple of hours which will
include this one. If you have any pending concerns with this one, speak up
soon. :)
--
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216309500
@swill I have gotten diverted from review. Hoping to pick up today.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216309958
@jburwell no worries, I know how that goes. :) Thanks for your support
regardless...
---
If your project is set up for it, you can reply to this email and have y
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61776712
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
---
@@ -0,0 +1,127 @@
+// Licens
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61776673
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
---
@@ -0,0 +1,116 @@
+// L
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61776838
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForClusterCmd.java
---
@@ -0,0 +1,105 @@
+/
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61776973
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForHostCmd.java
---
@@ -0,0 +1,107 @@
+// L
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61777066
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForZoneCmd.java
---
@@ -0,0 +1,105 @@
+// L
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61777144
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForClusterCmd.java
---
@@ -0,0 +1,105 @@
+//
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61777183
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForHostCmd.java
---
@@ -0,0 +1,107 @@
+// Li
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61777306
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
---
@@ -0,0 +1,128 @@
+//
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61777268
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForZoneCmd.java
---
@@ -0,0 +1,105 @@
+// Li
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61777563
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
---
@@ -0,0 +1,128 @@
+//
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61777665
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
---
@@ -0,0 +1,128 @@
+//
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61778682
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
---
@@ -0,0 +1,51 @@
+// Licensed to the Apache Softwar
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61778988
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
---
@@ -0,0 +1,51 @@
+// Licensed to the Apache Softwar
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61779846
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/driver/OutOfBandManagementDriverPowerCommand.java
---
@@ -0,0 +1,33 @@
+// Licensed to
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61780464
--- Diff:
engine/schema/src/org/apache/cloudstack/outofbandmanagement/dao/OutOfBandManagementDaoImpl.java
---
@@ -0,0 +1,163 @@
+// Licensed to the
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61780914
--- Diff:
engine/schema/src/org/apache/cloudstack/outofbandmanagement/dao/OutOfBandManagementDaoImpl.java
---
@@ -0,0 +1,163 @@
+// Licensed to the
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61781371
--- Diff:
engine/schema/src/org/apache/cloudstack/outofbandmanagement/dao/OutOfBandManagementDaoImpl.java
---
@@ -0,0 +1,163 @@
+// Licensed to the
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61781601
--- Diff:
engine/schema/src/org/apache/cloudstack/outofbandmanagement/dao/OutOfBandManagementDaoImpl.java
---
@@ -0,0 +1,163 @@
+// Licensed to the
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61787788
--- Diff:
plugins/outofbandmanagement-drivers/ipmitool/src/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolOutOfBandManagementDriver.java
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61789411
--- Diff:
plugins/outofbandmanagement-drivers/ipmitool/src/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolWrapper.java
---
@@ -0,0 +
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61792886
--- Diff:
plugins/outofbandmanagement-drivers/ipmitool/test/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolWrapperTest.java
---
@@ -
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61793974
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -251,8 +262,9 @@ public boolean start() {
}
private void init(Ma
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61795629
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementBackgroundTask.java
---
@@ -0,0 +1,45 @@
+// Licensed to the Apac
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61795721
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61798443
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61803751
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61804388
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61806348
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
---
@@ -0,0 +1,51 @@
+// Licensed to the Apache Softwar
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61807854
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61809934
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61810223
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61810461
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61810525
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61813461
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61813822
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61813894
--- Diff: server/test/com/cloud/resource/MockResourceManagerImpl.java ---
@@ -172,6 +173,12 @@ public Cluster getCluster(final Long clusterId) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61814182
--- Diff:
server/test/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceTest.java
---
@@ -0,0 +1,119 @@
+// Licensed to the Apach
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61814453
--- Diff:
server/test/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceTest.java
---
@@ -0,0 +1,119 @@
+// Licensed to the Apach
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61815144
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61815152
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61816081
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61816189
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61816897
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61817458
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843006
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForClusterCmd.java
---
@@ -0,0 +1,105 @@
+// L
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61842996
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
---
@@ -0,0 +1,116 @@
+// Lice
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843016
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForZoneCmd.java
---
@@ -0,0 +1,105 @@
+// Lice
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843036
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForZoneCmd.java
---
@@ -0,0 +1,105 @@
+// Licen
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843025
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForClusterCmd.java
---
@@ -0,0 +1,105 @@
+// Li
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843002
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
---
@@ -0,0 +1,127 @@
+// Licensed
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843007
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForHostCmd.java
---
@@ -0,0 +1,107 @@
+// Lice
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843031
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForHostCmd.java
---
@@ -0,0 +1,107 @@
+// Licen
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843039
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
---
@@ -0,0 +1,128 @@
+// Li
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843227
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
---
@@ -0,0 +1,128 @@
+// Li
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843281
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
---
@@ -0,0 +1,128 @@
+// Li
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843327
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
---
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software F
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r6187
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
---
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software F
1 - 100 of 201 matches
Mail list logo
