[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

2016-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1462 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

2016-04-07 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-207058799 @swill all green now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

2016-04-07 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206964457 Thanks @swill I totally understand --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

2016-04-07 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206963095 Thanks @bhaisaab, sorry to keep having you do that. I know it is just semantics, but I want to avoid doing `--force` merges. I got your travis fixes merged in

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

2016-04-07 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206961076 @swill done *though for purely JS change we may ignore CI errors if manual testing confirm a fix) --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

2016-04-07 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206960333 @swill I guess we have to do push -f; will do just now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

2016-04-07 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206954412 Is there a way to manually kick off travis on a specific PR, or is the only way to have the author do a `push -f`? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

2016-04-06 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206183076 @swill for the UI fix maybe in future we'll have selenium or jasmine/karma tests but for now we don't have anything other than manual testing for UI changes.

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

2016-04-05 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205671313 Thanks @terbolous, fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not