Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-219706255
Great, thanks @swill!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-219704376
This one is in good order and will make it in...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-219704080
### CI RESULTS
```
Tests Run: 86
Skipped: 0
Failed: 0
Errors: 1
Duration: 10h 57m 48s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-218004078
I will get this one into my CI queue. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-217858039
@DaanHoogland, the file has been renamed to make use of the python naming
standards
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-217839187
@nlivens thanks for the extra test effort you put into this. Can you rename
the marvin test to adhere to python naming standards (i.e. no camal case
underscore
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-217791958
@DaanHoogland, @alexandrelimassantana, could you review the PR once again
please?
---
If your project is set up for it, you can reply to this email and have your
r
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216785465
LGTM. Verified before and after fix and things are working as expected. The
integration test works fine and properly cleans up stuff on completion.
---
If you
Github user singalrahul commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216230102
test_deploy_vm_userdata_MultiNic.py script is added for the verification of
this Bug. It will verify that a user can deploy MultiNic VM when non-default
nic doe
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216208431
@alexandrelimassantana, you're right, I've splitted up the 3 different test
cases.
---
If your project is set up for it, you can reply to this email and have your
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216192751
That seems fair... But I think you could make 3 unit tests instead of 1 so
each one would have only 1 assert and only one behavior each. Other than tha
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216130431
@cristofolini, @alexandrelimassantana, I've extracted the internal loop
logic to a separate method and I've added a unit test for this behavior. This
logic couldn't
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216070253
@cristofolini that would not be that simple, there is userDataApplied
variable which is extern to the loop. It would be better to turn lines
2496-2515
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-215996953
@nlivens May I suggest extracting lines 2501-2514 to their own separate
method? That would also allow you to create separate test cases for each
possibility in
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-215447324
@nlivens I don't care for more scripts, just for a test showing the problem
so we no it doesn't regress. Whatever meets the goal easiest.
---
If your project
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-215421778
@DaanHoogland, you already have a UserData test script, do you want us to
add this test to the same script, or create a new one for it?
---
If your project is set
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-215410690
thought the code looks sane, could you be bothered to show the error in a
marvin test, Nick. It seems a good candidate to enter the regression suite.
---
If y
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-215336954
@DaanHoogland, @remibergsma, @swill, @jburwell, these are rather small
changes, if any of you could review, that would be great!
---
If your project is set up for
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1523
CLOUDSTACK-9365 : updateVirtualMachine with userdata should not errorâ¦
⦠when a VM is attached to multiple networks from which one or more
doesn't support userdata
You can merge this pull
20 matches
Mail list logo
