Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1561
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1561#issuecomment-221863597
@sanju1010 thanks for posting the test results with this change. This one
should be good now. Thanks everyone...
---
If your project is set up for it, you can
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1561#issuecomment-221821063
Simple change. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1561#issuecomment-221780495
Very small change , conversion of firewall port to string was not necessary
and that seems to be removed. Looks Good to me !!
---
If your project is set up for
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/1561
CLOUDSTACK-9388: Remove string conversion in assertion statement
Remove string convertion in Assertion statement, since the start port
parameter in listFirewallAPI response is of type
