Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222643203
Thanks @nitt10prashant for the making the changes. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222635435
@koushik-das as you have asked done following
1- moved check_string to test_data.py
2-provided test result
can you review changes .
---
If
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222439377
@swill i don't see any issue in my setup , please checktest result
[results.txt](https://github.com/apache/cloudstack/files/289139/results.txt)
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222438208
test result
Prashants-MacBook-Pro:test_routers_network_ops_TWUWR8 prashant$ cat
results.txt
Test redundant router internals ... ===
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-22559
Again the same problems and they seem related to this PR, so we will need
to review this...
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-22200
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 0
Duration: 3h 59m 06s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222140541
The failures seem relevant. I do have periodic issues with similar tests
in my CI env, so I will test this again to be sure there is an issue...
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222140055
### CI RESULTS
```
Tests Run: 78
Skipped: 0
Failed: 2
Errors: 4
Duration: 7h 21m 57s
```
**Summary of the
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222104760
Changes LGTM. Now the expected ping response can be configured in test_data
based on OS type.
@nitt10prashant Please post the test execution result.
---
