[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

2015-09-16 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/817#issuecomment-140777872 @bhaisaab Updated the PR. Tests run fine now. Thanks for your time! --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/817#issuecomment-140650340 Also there seems to be a license header issue (missing new line between header and package definition in the utils class). --- If your project is set up for it, yo

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/817#issuecomment-140648696 @borisroman not sure about the apache repo error, I'm having build failures when building locally due to getPreferredCharset method not avialable in StringUtils cla

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

2015-09-15 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/817#issuecomment-140301614 @bhaisaab Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

2015-09-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/817#issuecomment-140277680 4.5 was missing upgrade path, implemented that; please push again to force a travis build --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

2015-09-14 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/817 Cherry-pick PR #795 into 4.5 branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisroman/cloudstack 4.5 Alternatively you can rev