Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/849
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/849#issuecomment-151016206
@remibergsma thanks a lot for running the tests.. I rebased it with the
current master
---
If your project is set up for it, you can reply to this email and have y
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/849#issuecomment-150948113
LGTM, based on a set of tests that I run on this branch:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardwa
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/849#issuecomment-147090524
LGTM, lets' merge it after some tests. Thanks @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/849#discussion_r39960628
--- Diff: api/src/org/apache/cloudstack/context/CallContext.java ---
@@ -90,7 +90,13 @@ public void putContextParameter(Object key, Object
value) {
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/849#discussion_r39843941
--- Diff: api/src/org/apache/cloudstack/context/CallContext.java ---
@@ -90,7 +90,13 @@ public void putContextParameter(Object key, Object
value) {
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/849
Cloudstack-8816 some of the events do not have resource uuids
The key objects in the context map are sometimes String and sometimes
object. This causes missing uuids when an entity put in the c
