Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/857#issuecomment-173197191
Ping @remibergsma @borisroman
I don;t have a way to test it now, but looked at the code - just like
@DaanHoogland @wido and @runseb did. I trust the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/857#issuecomment-172329794
one small remark on the comment but code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/857#discussion_r49947012
--- Diff:
plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
---
@@ -507,6 +512,21 @@ public synchronized boole
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/857#issuecomment-172321551
Ping @borisroman @DaanHoogland @wilderrodrigues Can you guys review this
please? Seems like a good fix.
---
If your project is set up for it, you can reply to t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/857#issuecomment-144345855
@runseb In a prefect world, one would still run the tests against it to
verify they still all pass. Maybe we can execute the basic VM life cycle test
(smoke/test
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/857#issuecomment-144317611
@remibergsma that one is tough to test as @karuturi mentions. so I am with
@wido here +1 on code review. Small enough.
We need to think further on how to handle co
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/857#issuecomment-142722939
@remibergsma, my LGTM was based on the code. I was not able to fully test
it. I checked the diff and it was very small
---
If your project is set up for it, you can re
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/857#issuecomment-142697372
Hi @wido can you please add what you tested so the person to do the other
review can focus on something else? Thanks!
---
If your project is set up for it, you
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/857#issuecomment-142581607
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/857
Cloudstack-8885 added blocked connection listener for rabbitmqeventbus
When rabbitmq connections are blocked(for example when rabbitmq is
server is out of space), all the cloudstack threads
11 matches
Mail list logo
