Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/654
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/654#issuecomment-131214770
@bhaisaab Indeed, let's fix forward when needed :-) There's always a risk,
but I'm happy to see this work being done :+1:
---
If your project is set up for it,
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/654#issuecomment-131212079
@DaanHoogland I agree, we should only squash if there is no value to have
the commits separated. I usually ask for squashing when feedback was processed
in a sep
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/654#issuecomment-131181130
You know I am a great advocate of not squashing, right. All commits are
atomic. Yes there is a lot because the work has also been scattered and a lot.
---
If y
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/654#issuecomment-131179496
Another way of fixing a regression could be to simply fix the issue,
instead of reverting at all.
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/654#issuecomment-131178239
All kinds of regressions may be introduced. This is (one of the reasons)
why I will not squash. for a single regression we only have to revert a single
commit,
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/654#issuecomment-131175032
look alright, but could it introduce any regressions in the upgrade path?
Also, I would love to see a single squashed patched with the changes given ~30
patches for
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/654#issuecomment-131164822
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/654#issuecomment-129990097
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/654#discussion_r36774764
--- Diff:
services/console-proxy/server/src/com/cloud/consoleproxy/vnc/packet/server/RawRect.java
---
@@ -50,26 +52,27 @@ public void paint(Buffer
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/654#discussion_r36167090
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/SnapshotDescriptor.java ---
@@ -166,12 +168,7 @@ public void removeDiskReferenceFromSnapshot
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/654#discussion_r36166742
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/SnapshotDescriptor.java ---
@@ -166,12 +168,7 @@ public void removeDiskReferenceFromSnapshot(
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/654#discussion_r36166324
--- Diff: utils/src/com/cloud/utils/AutoCloseableUtil.java ---
@@ -0,0 +1,20 @@
+package com.cloud.utils;
--- End diff --
License?
-
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/654#discussion_r36141245
--- Diff: utils/src/com/cloud/utils/AutoCloseableUtil.java ---
@@ -0,0 +1,20 @@
+package com.cloud.utils;
+
+import org.apache.log4j.Log
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/654#discussion_r36141156
--- Diff: framework/db/src/com/cloud/utils/db/DbUtil.java ---
@@ -43,8 +43,10 @@
import org.apache.log4j.Logger;
+import static
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/654
Cloudstack 8656: do away with more silently ignoring exceptions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack
16 matches
Mail list logo
