[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127398255 two lgtm and succesful travis, merge gives no conflicts but will do a local build before push anyway --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127359986 I just had a comment on 87ae150. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127357042 @mike-tutkowski sorry didn't notice your reply, I added a view more. Can you have a look? --- If your project is set up for it, you can reply to this email and

Re: [GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread Mike Tutkowski
Yes On Monday, August 3, 2015, DaanHoogland wrote: > Github user DaanHoogland commented on the pull request: > > https://github.com/apache/cloudstack/pull/649#issuecomment-127284140 > > @mike-tutkowski are you alright with this now (merge-level allright;)? > > > --- > If your project is

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127284140 @mike-tutkowski are you alright with this now (merge-level allright;)? --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-03 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127174572 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-02 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127112655 Aside from a few comments on 04e9083c3199effa295e47bc617b9b406adb6109, LGTM. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

2015-08-02 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/649 Cloudstack 8656: do away with silently ignoring exceptions You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CLOU