[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-18 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/476#issuecomment-113129131 @bhaisaab ignore my previous comment. looks like code change was in the other PR. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-18 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/476#discussion_r32721772 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -926,7 +926,7 @@ protected void checkIfPodIsDeletable(final long podId)

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-18 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/476#issuecomment-113126424 @bhaisaab did travis CI run on the updated PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-18 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/476#discussion_r32715161 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -926,7 +926,7 @@ protected void checkIfPodIsDeletable(final long podI

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-18 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/476#discussion_r32710471 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -926,7 +926,7 @@ protected void checkIfPodIsDeletable(final long podId)

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-18 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/478#issuecomment-113081335 travis job timedout. Change looks good to me. Merging on master --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/478 Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRI… …NG warnings in DatabaseConfig.java You can merge this pull request into a Git repository by running: $ git pul

[GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/476 Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRI… …NG warnings in ConfigurationManagerImpl.java You can merge this pull request into a Git repository by running: