[GitHub] cloudstack pull request: Fix 4 findbugs warnings in JuniperSrxReso...

2015-06-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/399#issuecomment-111985640 Patch fails for some reason --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Fix 4 findbugs warnings in JuniperSrxReso...

2015-06-15 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/399#issuecomment-111994620 perhaps due to other changes in base file? I've rebased with current master, can you retry @bhaisaab ? :) --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: Fix 4 findbugs warnings in JuniperSrxReso...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/399 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix 4 findbugs warnings in JuniperSrxReso...

2015-06-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/399#issuecomment-112170872 @rsafonseca works now, merging. Thanks for the PRs :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Fix 4 findbugs warnings in JuniperSrxReso...

2015-06-12 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/399 Fix 4 findbugs warnings in JuniperSrxResource Data should be read and written in UTF-8 to the SRX Buffers were being used for reading but not for writing, PrintWriter was auto-flushing