GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1465
Fix concurrency issue on virtual router
The json files now have UUIDs to prevent them from getting overwritten
before they've been executed. Prevents config to be pushed to the wrong router
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1465#discussion_r58923375
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh ---
@@ -91,7 +91,7 @@ do
done < $cfg
#remove the configuration file,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1465#issuecomment-207044590
code LGTM running integration suite
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1465#issuecomment-207051489
@DaanHoogland This can be pointed towards 4.7 so I will close this and open
one to 4.7 instead of master.
---
If your project is set up for it, you can reply t
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1465
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1465#discussion_r58927425
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java
---
@@ -104,13 +109,25 @@ public static AbstractConfigI
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1465#discussion_r58927692
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java
---
@@ -104,13 +109,25 @@ public static AbstractConfigI
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1465#issuecomment-207054605
it was already started :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1465#discussion_r58927993
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -300,6 +303,8 @@ public ExecutionResult cr
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1465#discussion_r58927653
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -292,6 +292,9 @@ public ExecutionResult ex
10 matches
Mail list logo
