[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/445#issuecomment-112741518 LGTM I don't trust the build failures on this and will do a test build --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-17 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/448#issuecomment-112744837 travis timeout but it seems the runtime check might return a null. looking further getDetails is never called in the system it seems. Merging --- If your

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/448 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/453 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/447 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/449 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/444 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManager… …Impl.java Assert isn't used in runtime, null is properly checked in method You can merge this pull

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/448 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVO… ….java Assert isn't used in prod runtime, null is checked in method You can merge this pull request into a

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/451 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java Assert isn't used in prod runtime You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/450 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in DataCenterVO… ….java Assert isn't used in prod runtime You can merge this pull request into a Git repository by running:

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/455 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in UserVmJoinVO… ….java Assert isn't used in prod runtime You can merge this pull request into a Git repository by running:

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/446 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDis… …patcher.java Assert isn't used in prod runtime, null is properly checked in method You can merge this

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/453 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManager… …Impl.java Assert isn't used in prod runtime You can merge this pull request into a Git repository by

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/445 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachi… …neManagerImpl.java Removed two unnecessary null checks as this piece of code will only run if answer is

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/452 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in ServiceOffer… …ingVO.java Assert isn't used in prod runtime You can merge this pull request into a Git repository by

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/456 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in IpAddressMan… …agerImpl.java Assert isn't used in prod runtime You can merge this pull request into a Git repository by

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/447 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCe… …nterVO.java Assert isn't used in prod runtime, null is checked in method You can merge this pull request

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/449 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrche… …strator.java If answer is null, method will throw ConnectionException in line 3016 as satisfied by

[GitHub] cloudstack pull request: Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_N...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/454 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in RpcProviderI… …mpl.java Assert isn't used in prod runtime You can merge this pull request into a Git repository by