[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/505 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/505 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in Upgrade410to420.java You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-18 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/477#issuecomment-113097972 Was already asleep by the time travis finished running hehe... removed trailing space, waiting for travis again :) --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-18 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/475#issuecomment-113083555 travis job failure is unrelated. The change looks good to me. Merging on master --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-18 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/477#issuecomment-113081631 checkstyle issue [INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ cloud-server --- [INFO] Starting audit... /home/jenkins/jenkin

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/473 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/473#discussion_r32663864 --- Diff: engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java --- @@ -645,8 +643,9 @@ public boolean remove(Long id) { PreparedStat

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/477 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in ConfigurationServerImpl.java You can merge this pull request into a Git repository by running: $ g

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/473#discussion_r32660448 --- Diff: engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java --- @@ -645,8 +643,9 @@ public boolean remove(Long id) { PreparedSt

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/475 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in AsyncJobDaoImpl.java You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/474 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in PrimaryDataStoreDaoImpl.java You can merge this pull request into a Git repository by running: $ g

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-17 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/473 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in UserVmDaoImpl.java detail field was vulnerable You can merge this pull request into a Git repo

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/441 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/442 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in Upgrade30xBase.java There was no risk of sql injection here, nor any need to use PreparedState

[GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...

2015-06-14 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/441 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING… … warning in Upgrade2214to30.java There was no risk of sql injection here, nor any need to use PreparedStat