Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/461#issuecomment-112313269
convinced, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/461
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/461
Fix findbugs warning in VmwareStorageManagerImpl.java
Any encoding would do fine as it's just used to generate a UUID. Sticking
with UTF-8 for consistency
You can merge this pull request
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/461#discussion_r32465953
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -256,7 +256,7 @@ public Answer
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/461#discussion_r32472910
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -256,7 +256,7 @@ public Answer
