[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...

2015-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/757 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...

2015-08-28 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/757#issuecomment-135661617 Tested on Ubuntu 12.04 with mysql 5.5.41-0ubuntu0.12.04.1-log, it works . --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...

2015-08-28 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/757#issuecomment-135658100 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...

2015-08-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/757#issuecomment-135519152 Tested CentOS 6 which has MySQL 5.1 and it works fine. The other versions I don't have at hand now. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...

2015-08-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/757#issuecomment-135503642 I guess we simply need to test this for mysql 5.1.x, 5.5.x, 5.6.x; once it runs we can merge this. --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...

2015-08-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/757#issuecomment-135454714 Assuming the tests will pass: LGTM What I tested: - the new query has the same result as the old ones - the build now works again on CentOS 7 using Mar

[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...

2015-08-27 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/757#issuecomment-135453825 description of the issue: http://markmail.org/message/7isvqsur2preppvl http://markmail.org/message/t47bdpkhg6j4hhlb --- If your project is set up for it,

[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...

2015-08-27 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/757 Fix schema-421to430.sql issue after MariaDB upgrade @remibergsma @wido Can you test it? You can merge this pull request into a Git repository by running: $ git pull https://github.com/u