[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/114#issuecomment-85469871 this is the commit https://github.com/apache/cloudstack/commit/52ffccff5f1436dd5762fcc90050aadaf82eedad --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/114#issuecomment-85466253 @jiangyt I'm pushing a fix that I believe should work on Cygwin, please test that using master and let me know here or on dev ML. The fix at least won't break on

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/114#issuecomment-85465336 Hi, this commit breaks for unix environments. So I've created a fix using yours which seems to work for me; can you test it on your cygwin environment? -

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-12 Thread Cookie-Wang
Github user Cookie-Wang commented on the pull request: https://github.com/apache/cloudstack/pull/114#issuecomment-78436172 @jiangyt thanks , i resolve my issue by this 。my cygwin is 2.8 and cloudstack is 4.4.2.thanks ! --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/114#discussion_r26293610 --- Diff: tools/apidoc/build-apidoc.sh --- @@ -62,7 +62,18 @@ set -e sed -e 's,%API_HEADER%,Root Admin API,g' $thisdir/generatetoc_header.xsl

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-12 Thread jiangyt
Github user jiangyt commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/114#discussion_r26299243 --- Diff: tools/apidoc/build-apidoc.sh --- @@ -62,7 +62,18 @@ set -e sed -e 's,%API_HEADER%,Root Admin API,g' $thisdir/generatetoc_header.xsl

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/114#issuecomment-78451206 @Cookie-Wang have you confirmed that this works for you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-12 Thread jiangyt
GitHub user jiangyt opened a pull request: https://github.com/apache/cloudstack/pull/114 Fix the bug when build apidoc under windows crygwin environment. Currently, when building apidoc under windows error occured caused by python can not understand the directory of gen_toc.py

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/114#issuecomment-78435060 @jiangyt thanks for the patch. LGTM but I'll wait for anyone who can confirm this on windows for us. Later, I'll test if it works for *nix environment will merge