Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/818
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-152496955
LGTM I ran the compile on this one and did a code review.
@remi, no changes since your last check, you can merge at your will
---
If your project is set up
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-152421311
@DaanHoogland Sorry It was something to do with my IDE's settings.
Corrected and rebased.
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/818#discussion_r43429125
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkVO.java ---
@@ -616,7 +616,8 @@ public void setStrechedL2Network(boolean
strechedL2Network)
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-152282736
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-150780848
@kansal I see many issues on the tests, but I think they're not introduced
by you. I rebased locally and run some tests and then it looks much better.
Please reb
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-143644210
@remibergsma Rebased against the master. Please have a look. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-143590314
@kansal Ok, please rebase against current master so we can run the tests
against this branch.
---
If your project is set up for it, you can reply to this email
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-140984295
@remibergsma I tested it on my local setup and worked fine. Maybe you can
also check to make sure I haven't missed anything.
---
If your project is set up for it, yo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-140858308
Did anyone validate the functionality or do you want me to do that?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-140727278
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-140650519
LGTM, @kansal can you git commit --amend the message to reflect the JIRA ID
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-140339650
@remibergsma Yes its CLOUDSTACK-8844. It's already syncing the comments in
the JIRA issue.
---
If your project is set up for it, you can reply to this email and hav
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-140171936
@kansal Thanks! Can you add the Jira issue id please? Looks like
CLOUDSTACK-8844, right?! If you add it, it will also put a comment on the Jira
issue.
---
If y
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/818
Fixed: Network Update from RVR offering to Standalone offering fails
Problem: Moving a RVR network offering to standalone makes the status of
VR's as UNKNOWN and Redundant Router marked with YES.
15 matches
Mail list logo
