Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1501
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-213104146
Thanks, everyone.
Just as an FYI, the way I tested this was by running one of my Marvin tests
and no longer passing in "ispublic" when creating a
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212908719
I am pretty confident with this one and we have the LGTM code reviews
required, so I will add this to my merge queue to be merged today. Thanks...
---
If your
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212800599
LGTM based on code review @mike-tutkowski cc @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212797997
LGTM, cc @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212767179
LGTM based on code review @mike-tutkowski can you provide test results
---
If your project is set up for it, you can reply to this email and have your
Github user cloudsadhu commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212766999
LGTM based on the code review !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/1501
Fixing an issue in Marvin around creating a template from a snapshot
This fixes the following ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-9354
The problem was that
