Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/722#issuecomment-134097022
LGTM, merging. Thanks @miguelaferreira for fixing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/722#issuecomment-134105943
@bhaisaab
You are very welcome.
Just one thing, when I look at master I see this PR was not merged. I mean,
there is no merge commit, and
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/722
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/722#issuecomment-134107177
@miguelaferreira yeah, I could not make the git-pr script work on my
system; so used the old one. have figured the issue, will use the git-pr script
next time.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/722#issuecomment-132925325
ping @karuturi @bhaisaab
Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/722
Fixing syntax error introduced in PR #717
Commit 0062ff2672e257f2a4290e054e23ef4333a34983 in PR #717 introduced a new
parameter in two constructors. However, there is a test class
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/722#issuecomment-133295718
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
