[GitHub] cloudstack pull request: Get usage records new input format start ...

2015-04-25 Thread svscorp
Github user svscorp commented on the pull request: https://github.com/apache/cloudstack/pull/191#issuecomment-96160523 Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: Get usage records new input format start ...

2015-04-25 Thread svscorp
Github user svscorp closed the pull request at: https://github.com/apache/cloudstack/pull/191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Get usage records new input format start ...

2015-04-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/191#issuecomment-96117513 @svscorp somehow asfgit failed to close it, please close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: Get usage records new input format start ...

2015-04-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/191#issuecomment-96111919 LGTM thanks @svscorp merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: Get usage records new input format start ...

2015-04-24 Thread svscorp
Github user svscorp commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/191#discussion_r29093521 --- Diff: server/src/com/cloud/usage/UsageServiceImpl.java --- @@ -224,11 +224,11 @@ public boolean generateUsageRecords(GenerateUsageRecordsCmd cmd) {

[GitHub] cloudstack pull request: Get usage records new input format start ...

2015-04-24 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/191#discussion_r29092546 --- Diff: server/src/com/cloud/usage/UsageServiceImpl.java --- @@ -224,11 +224,11 @@ public boolean generateUsageRecords(GenerateUsageRecordsCmd cmd) {

[GitHub] cloudstack pull request: Get usage records new input format start ...

2015-04-24 Thread svscorp
GitHub user svscorp opened a pull request: https://github.com/apache/cloudstack/pull/191 Get usage records new input format start date end date (for 4.5 branch) Port of an improvement from PR: #185 @bhaisaab @kishankavala Here it is. You can merge this pull request into a