Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1155#issuecomment-161569317
Will run some tests to double check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1155
Merge 4.6
there is one (simple) conflict so for formailty's sake I make this a pull
request.
@utscweizhou en @remibergsma please have a look/test-run
You can merge this pull request
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1155#issuecomment-161568869
LGTM,
code are almost same to #1029 , fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1155#issuecomment-161745983
LGTM, run some tests and they are all fine:
```
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName:
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1071
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1071#issuecomment-157168301
LGTM:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1071#issuecomment-157169270
@DaanHoogland @wilderrodrigues @miguelaferreira Can either of you review so
we can merge this and open master for new features?
---
If your project is set up
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1071#issuecomment-157286509
Hi @remibergsma and @karuturi
Went through the code, which was quite straight forward. Based on that,
this PR LGTM :+1:
Cheers,
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1071#issuecomment-156980076
Thanks @karuturi will give it a test-drive soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1071#discussion_r44907513
--- Diff: build/replace.properties ---
@@ -26,4 +26,4 @@ AGENTLOG=logs/agent.log
MSMNTDIR=/mnt
COMPONENTS-SPEC=components.xml
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/1071
Merge 4.6 release branch to master
Initial merge of 4.6 to master
ignored pom.xml version number changes and changes to debian/changelog and
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1071#discussion_r44907228
--- Diff: build/replace.properties ---
@@ -26,4 +26,4 @@ AGENTLOG=logs/agent.log
MSMNTDIR=/mnt
COMPONENTS-SPEC=components.xml
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1071#issuecomment-157299325
Had a look yesterday and lgtm, didn't want to comment untill I saw the
test results. (It seemed so small ;)
---
If your project is set up for it, you can
14 matches
Mail list logo
