[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...

2015-06-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/342#issuecomment-107522610 Travis is green, merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...

2015-06-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/342#issuecomment-107523248 @rsafonseca oh wait, since you testing it. I'll wait for you to come back. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...

2015-06-01 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/342 Mocking the Connect object used in the LibvirtMigrateCommandWrapper. - When executing the tests in an environment where Libvirt is also installed, it caused errors. Hi

[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...

2015-06-01 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/342#issuecomment-107454748 LGTM :D Will test it out later! Thanks for this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...

2015-06-01 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/342#issuecomment-107663305 [INFO] Apache CloudStack Plugin - Hypervisor KVM . SUCCESS [6.987s] Perfect :) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...

2015-06-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/342#issuecomment-107674315 @wilderrodrigues done, merged on master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...

2015-06-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/342 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...

2015-06-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/342#issuecomment-107672506 Awesome!!! :) Thanks for testing. @Roh it: could you please merge it? :) Cheers, Wilder Sent from my iPhone