[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2015-03-04 Thread runseb
Github user runseb closed the pull request at: https://github.com/apache/cloudstack/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

Re: [GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2015-01-23 Thread Rohit Yadav
In that case, only Sebastien can close it since he created the PR. Regards. On Friday 23 January 2015 09:09 PM, Ian Duffy wrote: second message from seb says he messed up the commit so I'd imagine its safe to close Rohit. On 23 January 2015 at 15:01, bhaisaab wrote: > Github user bhaisaab com

Re: [GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2015-01-23 Thread Ian Duffy
second message from seb says he messed up the commit so I'd imagine its safe to close Rohit. On 23 January 2015 at 15:01, bhaisaab wrote: > Github user bhaisaab commented on the pull request: > > https://github.com/apache/cloudstack/pull/62#issuecomment-71205228 > > If it's in good state,

[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2015-01-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/62#issuecomment-71205228 If it's in good state, let's merge? If it's old and junk, let's close? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2014-12-22 Thread runseb
Github user runseb closed the pull request at: https://github.com/apache/cloudstack/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2014-12-22 Thread runseb
GitHub user runseb reopened a pull request: https://github.com/apache/cloudstack/pull/62 NGUI: Added more functionalities, final patch for angular based UI This was a patch from Shiva Teja that handed up in my inbox because review board could not handle it. It adds some function

[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2014-12-22 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/62#issuecomment-67858405 the Flask stuff is just old inheritance from us trying to RESTify the cloudstack API…. I do like the idea of having a client side UI. Just like ec2stack which can

[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2014-12-22 Thread shivateja
Github user shivateja commented on the pull request: https://github.com/apache/cloudstack/pull/62#issuecomment-67856339 I'd love to take this up but I'm currently at Amazon and I legally can't touch this. +1 for adding bower for package management and gulp as the build tool.

[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2014-12-22 Thread imduffy15
Github user imduffy15 commented on the pull request: https://github.com/apache/cloudstack/pull/62#issuecomment-67850765 I'm out cramming for exams like crazy over the christmas. Would probably start this from scratch to be honest. I dislike the flask part of it, angularjs

[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2014-12-22 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/62#issuecomment-67836369 Ok corrected my commit. Again this is from Shiva during the GSoC 2013 program. Someone should check exactly how it works, check the RAT is passing etc This has m

[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2014-12-22 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/62#issuecomment-67833967 Don't bother, I messed up the commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: NGUI: Added more functionalities, final p...

2014-12-22 Thread runseb
GitHub user runseb opened a pull request: https://github.com/apache/cloudstack/pull/62 NGUI: Added more functionalities, final patch for angular based UI This was a patch from Shiva Teja that handed up in my inbox because review board could not handle it. It adds some functional