Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78455032
@bhaisaab @likitha cool thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78449863
@snuf @likitha yeah, RAT expects a certain format. Just fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78339080
That's ok @bhaisaab you will be fine, @snuf is the huggy type you two can
get emotional about that code at the next cloudstack day.
---
If your project is set up for
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78436606
@likitha Hmm the format is indeed different, though the content is the
same, mine is the one that comes with eclipse and has a full line of * at the
top and bottom and i
Github user likitha commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78435972
Seems to have caused the RAT check to fail. I do see the license headers in
the new files, so I guess the format is not an exact match?
(https://builds.apache.org/job
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/113
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78428527
@runseb true that :)
@snuf we're good as long as the bugs are in the plugin itself and don't
affect the core. Looking at the code, does not look like the sev
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78336094
@bhaisaab thanks man!, it's bound to have some bugs and nasty bits here and
there. Already have NSX/NVP integration on the map for the next iteration
though :)
I'll
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78328589
@snuf after a quick look at the diff I feel so emotional with the code I'm
seeing, neat stuff :) :astonished:
---
If your project is set up for it, you can reply t
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78327336
Hey @snuf thanks for that! It makes it easier to everyone to review and
merge your stuff. First thing tomorrow morning!
---
If your project is set up for it, you ca
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/99#issuecomment-78311833
@bhaisaab move this into https://github.com/apache/cloudstack/pull/113
which is a new request, and a bit more condensed.
---
If your project is set up for it, you ca
Github user snuf closed the pull request at:
https://github.com/apache/cloudstack/pull/99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
GitHub user snuf opened a pull request:
https://github.com/apache/cloudstack/pull/113
Ovmsupport 3.2.1/3.3.x rebased and condensed in one single commit.
@bhaisaab
Rebasing the other stuff was a pain (4400 commits behind is no pleasure).
Decided to do a "re-implement" agains
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/99#issuecomment-77811087
@snuf too many merge conflicts if I merge from your branch to master
branch. This PR is for merging your branch to the ovmsupport branch. Please go
ahead and merge it
Github user ghxandsky commented on the pull request:
https://github.com/apache/cloudstack/pull/99#issuecomment-77675935
So good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
15 matches
Mail list logo
