Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/848
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-152291324
code reviewed as requested by @remibergsma no comments. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-152120874
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151927952
@remibergsma @insom I deleted the other pull jobs to avoid this confusion.
Sometimes jenkins reports the wrong build being busy. Let's see if this
behaviour is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151879029
Hi @Insom, Jenkins succeeded, see:
https://builds.apache.org/job/cloudstack-pull-analysis/1034/ There is a
different job with a slightly different name ;-)
---
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151859204
Hi @remibergsma - it looks like this Jenkins job is disabled?
https://builds.apache.org/job/cloudstack-pull-requests/ -- I can confirm the
tests pass on my rebased bra
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151841925
Hi @insom It might be rotated already. Usually when you force push your
commits to the branch again, Jenkins will notice this and run again. I think
that is the
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151805043
@remibergsma Travis seems happy but Jenkins isn't (but I can't view the
Jenkins output, it's 404ing :|). I'll run the tests for the rebased version
manually and see if
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151801262
@michaelandersen can you review this please?
@insom Travis failed, please investigate or push again. Thanks!
---
If your project is set up for it, you can re
Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-151097482
@remibergsma Hi, rebased and pushed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-150838939
@insom Please rebase against current master so we can run some tests.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
re
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/848#issuecomment-150838920
@michelandersen can you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/848
Pass LbProtocol down to the HAProxyConfigurator
This will let us specify a new load balancer protocol
(tcp-proxy) which enables HAProxy's `send-proxy`
functionality.
`send-proxy` /
13 matches
Mail list logo
