Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/915#issuecomment-147193430
LGTM(code review).
As @remibergsma said on pr #912 this should be included in 4.6
since it already has two reviews with Daan testing it, I am going to merge
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/915#issuecomment-147202774
Thanks @milamberspace @karuturi @bhaisaab @DaanHoogland..
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/915#issuecomment-147089366
UI change LGTM. Thanks @milamberspace
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/915#issuecomment-146485465
had a fresh install and added a second zone using the wizard. works as a
charm.
---
If your project is set up for it, you can reply to this email and have
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/915#issuecomment-146580968
Thanks @DaanHoogland for the testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/915#issuecomment-146739606
ran the tests as well
all successful except for a skip of a test requiring two hosts.
Test router internal advanced zone ... === TestName:
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/915#issuecomment-146105944
@milamber as you mentioned in #912 I did a rebuild of the entire server
running the ms. I will find the time to test this and check the browser for
relics.
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/915
Pr 906 912 bug zone wizard and adv search popup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milamberspace/cloudstack
