[GitHub] cloudstack pull request: Prevent live-lock in NSX API client

2015-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Prevent live-lock in NSX API client

2015-12-07 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1178#issuecomment-162616790 @miguelaferreira gave me some explanations about the problem and how he was going to fix it. I went through the code and also checked the tests he wrote.

[GitHub] cloudstack pull request: Prevent live-lock in NSX API client

2015-12-06 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1178#issuecomment-162287978 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: Prevent live-lock in NSX API client

2015-12-05 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1178#issuecomment-162231638 Ok, I'll post results later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack pull request: Prevent live-lock in NSX API client

2015-12-05 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1178#issuecomment-162225746 ping @nvazquez would you be able to test this PR? The new marvin test I added requires two hosts in order to test the NSX tunnel between them. ---

[GitHub] cloudstack pull request: Prevent live-lock in NSX API client

2015-12-05 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1178#issuecomment-162225661 As for testing, I've built the entire project executing all unit tests (including the one I've added to prevent a regression on this issue), the existing ma

[GitHub] cloudstack pull request: Prevent live-lock in NSX API client

2015-12-05 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/1178 Prevent live-lock in NSX API client The NSX api client relies on a sequence of responses to identify the need to authenticate and to follow redirects. In order to avoid live-locks, the