[GitHub] cloudstack pull request: Privtmpl

2016-04-20 Thread pavanb018
Github user pavanb018 closed the pull request at: https://github.com/apache/cloudstack/pull/566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Privtmpl

2016-01-24 Thread rodrigo93
Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/566#issuecomment-174322999 Why does this PR still open? Shouldn't be closed? Seems that has been resolved already... --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Privtmpl

2015-07-17 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/566#issuecomment-122240477 I think it looks good? But it depends on earlier PR's I think since it's only a test --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Privtmpl

2015-07-08 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/566#discussion_r34134668 --- Diff: test/integration/component/test_project_template.py --- @@ -0,0 +1,172 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Privtmpl

2015-07-08 Thread pavanb018
Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/566#issuecomment-119533762 test_project_private_template (integration.component.test_project_template.TestProjectPrivateTemplate) ... === TestName: test_project_private_template | Status :

[GitHub] cloudstack pull request: Privtmpl

2015-07-08 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/566#discussion_r34134916 --- Diff: test/integration/component/test_project_template.py --- @@ -0,0 +1,172 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Privtmpl

2015-07-08 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/566#issuecomment-119511153 @pavanb018 You will have to add license headers to the new files --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Privtmpl

2015-07-08 Thread pavanb018
Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/566#issuecomment-119533859 On Advanced Zone: Test Deploy Virtual Machine ... === TestName: test_deploy_vm_with_tags | Status : SUCCESS === ok

[GitHub] cloudstack pull request: Privtmpl

2015-07-08 Thread pavanb018
Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/566#issuecomment-119533805 On Basic Zone: Test Deploy Virtual Machine ... === TestName: test_deploy_vm_with_tags | Status : SUCCESS === ok

[GitHub] cloudstack pull request: Privtmpl

2015-07-08 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/566#discussion_r34134700 --- Diff: test/integration/component/test_project_template.py --- @@ -0,0 +1,172 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Privtmpl

2015-07-08 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/566#discussion_r34134758 --- Diff: test/integration/component/test_user_taglisting.py --- @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Privtmpl

2015-07-08 Thread pavanb018
GitHub user pavanb018 opened a pull request: https://github.com/apache/cloudstack/pull/566 Privtmpl Comments provided in PR 241 are addressed and the commits for those are in this PR. You can merge this pull request into a Git repository by running: $ git pull