Github user mike-tutkowski closed the pull request at:
https://github.com/apache/cloudstack/pull/653
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user mike-tutkowski reopened a pull request:
https://github.com/apache/cloudstack/pull/653
Reduce the lowest hypervisor snapshot reserve value from 50% to 10%
If the admin specifies a hypervisor snapshot reserve value that is below a
particular number, we want to just use
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/653#issuecomment-128159614
Sorry...I accidentally closed this PR without getting the code properly
into upstream (so re-opening it for a bit).
---
If your project is set up for it,
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/653
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/653#issuecomment-127532378
Changes LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/653#issuecomment-12753
great. thanks for the update @mike-tutkowski. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/653
Reduce the lowest hypervisor snapshot reserve value from 50% to 10%
If the admin specifies a hypervisor snapshot reserve value that is below a
particular number, we want to just use that
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/653#issuecomment-127426349
Definitely a valid point. It's something on my radar, but I just wanted to
put this quick fix in per a customer request. :)
On Mon, Aug 3, 2015 at
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/653#issuecomment-127425881
Of course I have something to nag about but LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/653#discussion_r36140697
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
---
@@ -352,8
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/653#issuecomment-127472162
Good points...I went ahead and used Math.max (I also replaced the magic
number with a private static final...it doesn't need to be user configurable at
the
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/653#issuecomment-127471522
:+1: with/without the minor change I suggested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/653#discussion_r36155878
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
---
@@ -352,8 +352,8
13 matches
Mail list logo
