[GitHub] cloudstack pull request: Removal of test/debug code.

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-139524401 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/794 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-139537389 Looks like what I meant @borisroman , LgreatTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/794#discussion_r39130315 --- Diff: core/src/com/cloud/storage/template/LocalTemplateDownloader.java --- @@ -159,16 +159,4 @@ public long download(boolean resume,

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/794#discussion_r39147704 --- Diff: core/src/com/cloud/storage/template/LocalTemplateDownloader.java --- @@ -159,16 +159,4 @@ public long download(boolean resume,

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-139247851 Still looks good to me. pom.xml should be there --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Removal of test/debug code.

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/794 Removal of test/debug code. Removed main() method from LocalTemplateDownloader.java You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-138858662 @borisroman I would like to see all the test-main removed as well but not without moving the actual test code into unit tests --- If your project is set up

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-138855244 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/794#discussion_r39081547 --- Diff: core/src/com/cloud/storage/template/LocalTemplateDownloader.java --- @@ -159,16 +159,4 @@ public long download(boolean resume,

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-139001822 @DaanHoogland True that. But then the discussion arises; until there are Unit Tests , do we keep this useless code? --- If your project is set up for it, you

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/794#discussion_r39085814 --- Diff: core/src/com/cloud/storage/template/LocalTemplateDownloader.java --- @@ -159,16 +159,4 @@ public long download(boolean resume,